invalid binary data type in pdfannotator_default_setting.allowanonymous

rwthmoodle / moodle-mod_pdfannotator

PDF Annotation Tool

19 stars 22 forks source link

invalid binary data type in pdfannotator_default_setting.allowanonymous #102

Open skodak opened 5 months ago

skodak commented 5 months ago

The binary data field type in Moodle should not be used at all - it is used in pdfannotator_default_setting.allowanonymous.

It looks like it was meant to a boolean with values 0 or 1 - that is integer with length 1, right?

I did not find any uses of this database table or field, maybe a solution could be to drop this table.

This problem was detected by tests in Vault admin tool - see https://github.com/lmscloud-io/moodle-tool_vault/blob/main/tests/local/xmldb/dbstructure_test.php

marinaglancy commented 3 months ago

I just saw this error in the tool_vault logs and found this issue. If Moodle is able to create a table from this definition, maybe vault should also be able to work with it, I'll look at it on the tool_vault side.

At the same time, there are more errors that MDLCode extension reports in the db/install.xml , not just the unused table:

pdfannotator