rwx-yxu / inventory

Inventory application that uses openfaas to deploy an api backend and vuejs front end.
0 stars 0 forks source link

Build and deployment actions should have a test api call. #21

Open rwx-yxu opened 2 years ago

rwx-yxu commented 2 years ago

Workflows should have a step to test call the API to ensure that migrations that fail will stop the action. Since moving to auto migration errors are a bit obfuscated since the actions just deploy and forget about it. I should include a step to make some API call to localhost at least on the build action. When deploying on my hardware, I should have a ping action to health check the API. If the migration failed, the function will not be running so it should fail. I don't think that a unit test would cover this since that would involve mocking and this is more of an issue with the deployment. I would say that the priority of this should be after getting the frontend service running, then I can come back and revise this. I may need to modify the workflow when doing it so I can wrap up that with this issue.