fix supplemental bug and add sanity test

rxaviers / cldr-data-npm

Npm module for Unicode CLDR JSON data

MIT License

42 stars 28 forks source link

fix supplemental bug and add sanity test #22

Closed alunny closed 9 years ago

alunny commented 9 years ago

Fixes #21

rxaviers commented 9 years ago

That was quick! Thanks.

Do you think it makes sense to do the same for the main files?

alunny commented 9 years ago

Yeah, that makes sense.

rxaviers commented 9 years ago

Landed. Released as 28.0.1. Thanks

rxaviers commented 9 years ago

PS: Landed on all previous branches as well. 27.x, 26.x, ...

rxaviers commented 9 years ago

Amended by the commit listed above ^.

alunny commented 9 years ago

Actually there's a bug that prevents this working as a dependency - fs.readdirSync reads relative to pwd, not to __dirname. So the script fails when it's called from a top level with cldr-data under node_modules.

Sorry about that - patch forthcoming.

rxaviers commented 9 years ago

I've already fixed it. :)

alunny commented 9 years ago

Nice, thanks :)

rxaviers commented 9 years ago

Are you talking about https://github.com/rxaviers/cldr-data-npm/commit/4303ce1444642e26f4ad5e95f778a74f341d7b42 or a fix on top of that?

alunny commented 9 years ago

I think that's right, trying 28.0.2 now.

rxaviers commented 9 years ago

;)