search

rxaviers / cldr-data-npm

Npm module for Unicode CLDR JSON data
MIT License
42 stars 27 forks source link

Version bump for adm-zip security vulnerability #75

Closed chrismichaelmurphy closed 2 years ago

chrismichaelmurphy commented 2 years ago

Package updated adm-zip under the cldr-data-downloader and updating the package under cldr-data-npm to address security vulnerability Link : https://github.com/rxaviers/cldr-data-downloader/commit/3b3b9675a6aac2736c596513c7a756086bca5413

rxaviers commented 2 years ago

After this merge, this module is failing to install

> cldr-data@36.0.1 install /private/tmp/node_modules/cldr-data
> node install.js

GET `https://github.com/unicode-cldr/cldr-core/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-dates-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-buddhist-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-chinese-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-coptic-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-dangi-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-ethiopic-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-hebrew-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-indian-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-islamic-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-japanese-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-persian-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-cal-roc-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-localenames-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-misc-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-numbers-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-segments-modern/archive/36.0.0.zip`
GET `https://github.com/unicode-cldr/cldr-units-modern/archive/36.0.0.zip`
Unpacking it into `./`
/private/tmp/node_modules/cldr-data-downloader/lib/unpack.js:145
                    fs.promises.mkdir(path.dirname(fileDestPath), {recursive: true})
                               ^

TypeError: Cannot read property 'mkdir' of undefined
    at /private/tmp/node_modules/cldr-data-downloader/lib/unpack.js:145:32
    at /private/tmp/node_modules/yauzl/index.js:575:7
    at /private/tmp/node_modules/yauzl/index.js:631:5
    at Immediate.<anonymous> (/private/tmp/node_modules/fd-slicer/index.js:202:5)
    at runCallback (timers.js:672:20)
    at tryOnImmediate (timers.js:645:5)
    at processImmediate [as _immediateCallback] (timers.js:617:5)
rxaviers commented 2 years ago

@chrismichaelmurphy since you are on it, I'd like to bring this to you attention #78