search

rxaviers / cldr-data-npm

Npm module for Unicode CLDR JSON data
MIT License
42 stars 28 forks source link

Fixes coverage definition in package.json #8

Closed tinganho closed 9 years ago

tinganho commented 9 years ago

This change makes defining coverage in a parent package.json available. No environmental variable needed. It works as specified in #6. It only look at the coverage in package.json if and only if cldr-data is defined in dependencies.

rxaviers commented 9 years ago

Awesome!

rxaviers commented 9 years ago

Please, confirm your DCO certification by adding signed-off to your commit message. https://github.com/rxaviers/cldr-data-npm/blob/master/DCO.md

rxaviers commented 9 years ago

It would also be good to have that new use case documented on README. If you don't have time for that, we can land this PR and I include it later.

tinganho commented 9 years ago

@rxaviers done. Included some docs in README.md too.

rxaviers commented 9 years ago

Landed, tagged and npm published. Thank you.