search

rxaviers / cldrjs

Simple CLDR traverser
MIT License
155 stars 30 forks source link

Fix wrong case of minLanguageId in the attributes #40

Closed gcastre closed 8 years ago

gcastre commented 8 years ago

Ref : #39

rxaviers commented 8 years ago

Excellent, thanks for your contribution. Please, two things: could you sign-off your commit (https://github.com/rxaviers/cldrjs/blob/master/DCO.md) and check if a commit introduced this problem or if this has been always this way? blame view could be special interesting for this. Knowing this info we may catch similar problems. Thanks

gcastre commented 8 years ago

It was changed from "languageId" (before change: https://github.com/rxaviers/cldrjs/commit/77933d613293cfe9c6b3ffe01939cfee1499d1e1#diff-1c90ff38a08209f9ebd4d05d1e43358eR112) to "minlanguageId" in the commit https://github.com/rxaviers/cldrjs/commit/f9572aa0164a8e4fcb5b7c4ae95957f2ced8e96a#diff-7eb52b366866677666470e019283c8eaL147

rxaviers commented 8 years ago

Ah! Thanks for the investigation, so it seems we're good to fix only this one.

rxaviers commented 8 years ago

Just let me know when the commit has the sign-off comment amended. You can force push to your branch.

gcastre commented 8 years ago

Just pushed the commit with the sign-off comment https://github.com/gcastre/cldrjs/commit/d177dc67ee4073790fb2b52ae43be8bbcb875ac7

rxaviers commented 8 years ago

Excellent, thank you @gcastre. Merged.