Tests (finally) - Githubissues

rxaviers / globalize-webpack-plugin

Globalize.js webpack plugin

Other

33 stars 27 forks source link

Tests (finally) #52

Closed rxaviers closed 7 years ago

rxaviers commented 7 years ago

It was time to have tests in place. This PR finally adds test cases, including ones actually using the generated production bundle.

Ideas for improvement are welcome:

We need to test webpack 1 and webpack 2.. Can we npm install both simultaneously? A little research showed it's a little hassle. Should we stop supporting both simultaneously and instead support each in different globalize-webpack-plugin versions instead?
How can I cleanly import a module from within the generated bundle. Currently, I'm using a little hack to do so.

rxaviers commented 7 years ago

I'm going ahead to merge this, but comments are always welcome.