search

rxaviers / globalize-webpack-plugin

Globalize.js webpack plugin
Other
33 stars 27 forks source link

fix hashing of RawModules #62

Closed jbellenger closed 7 years ago

jbellenger commented 7 years ago

webpack-2 appears to have a bug where RawModules can produce hash collisions. Since globalize-webpack-plugin-1.0.0 introduced use of RawModules, this package is susceptible to emitting chunks with different contents but unchanged chunkhashes. This can cause cdns and browser caches to unwittingly use old assets and lead to irksome bugs.

Even though the root issue appears to be in webpack, this package should be patched to work around the issue in the versions of webpack that it supports.

Additionally, the required webpack version here is downgraded to match what is required by react-globalize-webpack-plugin.

jbellenger commented 7 years ago

Amended diff to not bump package version. I believe this is good to go.