Make requirejs a dependency

[necolas]

Not sure why requirejs is a peerDependency, but npm@3 complains about it being missing and the app needing to install it.

[rxaviers]

requirejs isn't a peer dependency, it is a residue from previous code. Fixed. Thanks

[rxaviers]

Published 0.0.7 with this fix.

[necolas]

There's a require("requirejs") in this file though: https://github.com/rxaviers/react-globalize-compiler/blob/master/lib/dynamic-compiler.js

[rxaviers]

Thanks for pointing it out. The dynamic compiler was the previous code I had in mind, but I forgot it was still linked by index.js. Having said that, I regret making this incomplete-change a patch fix. My second attempt to fix this issue then is: (a) revert my attempt-one in a new patch release; (b) properly fix this in a new minor release.

• 0.0.8 reverts attempt-one
• 0.1.0 fixes this.

Please, just let me know if you still find any problem.

[necolas]

That resolves the npm3 issue, thanks. However, the dynamic compiler won't work without requirejs being installed.

[rxaviers]

You're welcome.

However, the dynamic compiler won't work without requirejs being installed.

I assume you aren't using it, but you're concerned about the correctness of the "solution". Please, correct me if I'm wrong and you're using the dynamic one.

I'm favoring the static compiler over the other here, because it's the one being used both in Globalize examples and react-globalize. You're correct that the dynamic compiler won't work without requirejs being installed. Peer dependency was correctly defined for that, the problem is that we cannot have optional peer dependencies. Therefore, a saner approach for the dynamic one would be to move it to a different project.

[rxaviers]

I'm also open for ideas.