rxbrad / es-theme-gbz35

Gameboy Zero 3.5" Theme for EmulationStation / RetroPie
52 stars 13 forks source link

Crashing ES #28

Closed jondeckert closed 4 years ago

jondeckert commented 4 years ago

When I select this theme, it’s crashing Emulation Station to the command prompt.

rxbrad commented 4 years ago

Hmm... It's working okay for me on these three different EmulationStation setups:

What platform are you running EmulationStation on? Retropie/Raspberry Pi? PC? Other? Also, which version of EmulationStation are you running?

I hate to throw it back in your court, but I wonder if something is misconfigured on your end? Also, are you maybe trying to view the theme in Grid View (it's not supported in this theme.. though I wouldn't think it'd crash ES outright).

Did it crash before I added openbor?

jondeckert commented 4 years ago

No problem, throwing it back my way. I'd rather help out. I am using RetroPie through a RetroFlag GpiCase with a Raspberry Pi Zero W. Not certain which version of Emulation Station but I am using the Gpi Case User's Group Image which is based on RetroPie 4.5.1. Where can I locate the version number? I don't recall it crashing before you added OpenBor. The crash happens when I attempt to switch to the theme via UI Settings and only via that theme. Any other themes I use, do not present a crash. I have uninstalled and reinstalled the theme and it persists. I am viewing the theme on auto, haven't tried grid for any themes.

rxbrad commented 4 years ago

I managed to get it to crash by attempting to add OpenBOR via the "Create New Custom Collection From Theme" option on my Pi Zero handheld. (I had to do it by that method, since OpenBOR gets dumped into the "Ports" menu by default when you install it)

So, maybe the version of ES on the Pi (Start button menu shows it to you in tiny text at the bottom) doesn't like something about the SVG file being used for the logo.

I'll do some more investigation and report back (might be tomorrow or so before I can get it fixed). Thanks for the heads up.

jondeckert commented 4 years ago

I appreciate you looking into it. Looks like I am running ES Version 2.84 from what I can tell from the small text.

rxbrad commented 4 years ago

I vectorized a new OpenBOR logo from scratch. Using the new logo, it no longer crashes EmulationStation when I view OpenBOR in RetroPie on my Pi Zero handheld.

jondeckert commented 4 years ago

Confirmed! Works and looks great! Thank you! No rush but would be great if this was also added to the dark version.

rxbrad commented 4 years ago

@jondeckert I actually updated the dark theme at the same time, so it should hopefully be good to go.