Improve criteria for duplicate students

[rxchell]

Steps to reproduce

1. Add duplicate students with all fields same except for the phone number. For example, add n/John Doe p/98765432 a/John street, block 123, #01-01 gl/LCM 1 add n/John Doe p/123 a/John street, block 123, #01-01 gl/LCM 1 add n/John Doe p/9123 a/John street, block 123, #01-01 gl/LCM 1

Expected

There should be an error message telling that the user has already been added into the list of persons.

Actual

All three students are added, but all of them have exactly the same address, which can cause confusion to the user.

How to improve the product

Add another criteria for duplicate students, which is having the same address, on top of having the same name and phone number.

Screenshot

[soc-se-bot]

Team's Response

We intentionally chose not to include addresses in duplicate checks because address strings are long and can be permutated in different ways. So, adding addresses in the duplication check would actually hinder the checks.

Acorn Street Blk 50 50 Acorn Street Blk 50 Acorn Street

Improving the address field to handle all the ways of typing the same address would require extra effort and is not in scope. We believe it is sufficient to use the name and phone number for duplicate checks as it is very unlikely for one person to have more than one phone number that they use to communicate on a regular basis.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---