rxdi / firelink

Firebase. gcloud and monorepos are not combining very well until they met @rxdi/firelink

MIT License

68 stars 9 forks source link

fix(main): when firebase crashes it is wrapped inside try catch causing to silent build fails #28

Closed Stradivario closed 2 years ago

Stradivario commented 2 years ago

Issue

Description

When we executing firelink command and the internal runner fails we are not throwing appropriate error code status to crash the process which causes the process to crash silently. Fixed by removing try/catch from the beginning of the program.

Type of change

[x] Breaking change

Checklist:

[x] Inside main.ts removed try/catch

jekozyra commented 2 years ago

Oh, this is great, thanks!