rxhanson / Rectangle

Move and resize windows on macOS with keyboard shortcuts and snap areas
https://rectangleapp.com
Other
25.48k stars 759 forks source link

Update Chinese translation #1010

Closed groverlynn closed 1 year ago

groverlynn commented 1 year ago

Drop redundant zh-Hant-TW as zh-Hant defaults to zh-Hant-TW. Update zh-Hans, zh-Hant and zh-Hant-HK to use consistent Apple glossary. Complete zh-Hant-HK localisation. Correct several minor mistakes in zh-Hans, zh-Hant, and zh-Hant-HK.

rxhanson commented 1 year ago

Drop redundant zh-Hant-TW as zh-Hant defaults to zh-Hant-TW.

I'll take your word for it :)

Thanks!

ChiahongHong commented 1 year ago

Hi, @groverlynn

There seems to be a variant Chinese character (異體字) here, 熒幕 here should be 螢幕.

https://github.com/rxhanson/Rectangle/blob/9fd9e3975bb9cccefc140434012328813d59e925/Rectangle/zh-Hant.lproj/Main.strings#L430

And then we don't use the term 屏/屏幕 in Taiwan, and I don't think Apple's translation terminology uses it either, at least I haven't seen it on macOS or iOS.

https://github.com/rxhanson/Rectangle/blob/9fd9e3975bb9cccefc140434012328813d59e925/Rectangle/zh-Hant.lproj/Main.strings#L374-L377

I'm not sure if Macau, which also uses Traditional Chinese (zh-Hant), uses the same terminology, so removing regional localization may not be a good idea.

groverlynn commented 1 year ago

@ChiahongHong Thanks for pointing out these.

You are absolutely right about 螢幕 instead of 熒幕. 半屏 could be replace by 一半. These should apply for both zh-Hant and zh-Hant-HK

As for zh-Hant-MO, it defaults to zh-Hant-HK which is present here. So, there should be no worries on that side. Also, there is no zh-Hant-TW or zh-Hant-MO at the MacOS system level. Unless you want to introduce Macau-specific glossary, there is really no need to create these abundant localisation which only adds burden for future updates.

@rxhanson Is there anyway for these minor updates?

rxhanson commented 1 year ago

I rolled those minor updates in myself, but definitely check it and make sure things look ok.

groverlynn commented 1 year ago

I rolled those minor updates in myself, but definitely check it and make sure things look ok.

They look okay to me.

rxhanson commented 1 year ago

Great, thanks.