search

rxhanson / Rectangle

Move and resize windows on macOS with keyboard shortcuts and snap areas
https://rectangleapp.com
Other
25.19k stars 748 forks source link

Added Lithuanian language translation #1139

Closed firebotQL closed 1 year ago

firebotQL commented 1 year ago

Added Lithuanian localisation.

firebotQL commented 1 year ago

If I've missed something, did incorrectly or there is any other feedback please let me know.

rxhanson commented 1 year ago

Thanks for contributing! There's just one comment from reading through it. Also, the file has to be registered in Xcode. I can do that if you don't know how.

firebotQL commented 1 year ago

Thanks for contributing! There's just one comment from reading through it. Also, the file has to be registered in Xcode. I can do that if you don't know how.

I will try add the file from Xcode when I return from work. Also, I've noticed that other translation contributions have included translations for RectangleLauncher/[language].lproj/Main.strings. Would you like me to work on that as well? Please let me know if this is something you'd also like me to complete.

firebotQL commented 1 year ago

@rxhanson I've added RectangleLauncher translations and included both localizations through Xcode. However, could you please take a look at the Main.storyboard file? I'm not certain why the heights and widths have changed in some of the elements. If they are incorrect, I'd appreciate it if you could fix them. I don't believe I've made any mistakes with any of the items, and it's possible that the newer Xcode made these changes by default. But not sure...

rxhanson commented 1 year ago

Thanks for the follow up. The launcher translation wasn't necessary (sorry, I need to update documentation around this and/or rip them all out). Xcode tends to make those size adjustments from time to time, and I'll make sure things look fine after a merge.

rxhanson commented 1 year ago

@firebotQL Just following up, in case you didn't catch the comment after your latest revision:

Looks like a few of the English keys got translated into Lithuanian, here and at the end. Would you mind making sure that the correct English keys are in? I'd give it a go myself, but sometimes these can move around between the different translation files and it's probably easier for you to check.

No rush on a reply, I don't have a release planned for a little while.

firebotQL commented 1 year ago

@firebotQL Just following up, in case you didn't catch the comment after your latest revision:

Looks like a few of the English keys got translated into Lithuanian, here and at the end. Would you mind making sure that the correct English keys are in? I'd give it a go myself, but sometimes these can move around between the different translation files and it's probably easier for you to check.

No rush on a reply, I don't have a release planned for a little while.

Yes, sorry. Did mean to look into it yesterday, but didn't have chance. Will try to address your comments today.

firebotQL commented 1 year ago

@rxhanson tagging you here as pushed the change yesterday. let me know if anything else is amiss.

rxhanson commented 1 year ago

Thanks!