search

rxhanson / Rectangle

Move and resize windows on macOS with keyboard shortcuts and snap areas
https://rectangleapp.com
Other
25.1k stars 742 forks source link

Fix typos in TerminalCommands #1299

Closed FireFingers21 closed 7 months ago

rxhanson commented 7 months ago

Thanks for contributing! One comment inline.

FireFingers21 commented 7 months ago

Gotcha, I'm not sure if this is what you meant, but modifer keys can be combined if you add their sums together, so I've changed the wording to reflect that

rxhanson commented 7 months ago

Sorry that there's a misunderstanding here. To understand better what's going on, you might want to look at this: https://en.wikipedia.org/wiki/Bitwise_operation

This is a bitwise OR, not a sum. A sum would not be the same and is not what you want here. If you open up the macOS calculator app and hit cmd+3, you'll see the developer calculator view, and you can try out ORing together values and see that they would be different from just adding them together. I think it's acceptable to just leave it what it was prior to your changes, or change it to "Modifier key values can be combined by OR operation"

FireFingers21 commented 7 months ago

I've tested several different combinations of modifier keys and adding the sum to combine them does actually work. The same applies when creating macOS's built-in "Hot Corners" from Terminal, which I have also done and re-verified.

rxhanson commented 7 months ago

Ah, you're right! There's no bit overlap, so it's the same as addition in this case.