search

rxhanson / Rectangle

Move and resize windows on macOS with keyboard shortcuts and snap areas
https://rectangleapp.com
Other
25.1k stars 742 forks source link

Fix title bar element detection #1300

Closed decodism closed 6 months ago

decodism commented 7 months ago

Fixes #1293. Search in children rather than just using the API.

rxhanson commented 7 months ago

Thanks! I'll test this out this weekend. I feel deceived by the Accessibility Inspector - when I was using it, I didn't see any children there; hence my workaround. Worth noting: I have had a scenario in the past, oddly enough with Outlook, where recursively going through the accessibility children resulted in an infinite loop & crash.

decodism commented 6 months ago

I can't say I've ever noticed this issue with the inspector. The infinite loop is due to an element containing itself. I was already handling this, but I've updated the PR to make it more robust.

rxhanson commented 6 months ago

Thanks again!