search

rxhanson / Rectangle

Move and resize windows on macOS with keyboard shortcuts and snap areas
https://rectangleapp.com
Other
25.6k stars 767 forks source link

Catalan translation is incomplete despite the translation being complete in the code #958

Closed fv3rdugo closed 1 year ago

fv3rdugo commented 1 year ago

I found a similar issue documented #254

macOS version: 12.6 (21G115) Rectangle version: 0.60 Logs if applicable (In Rectangle menu, hold option, "View Logging..."): Non applicable

Some strings in the the catalan version aren't translated, eg: "Left Half", "Center Half", "Top Left", "Almost Maximize", ... I've checked the localization files, and all the strings seem to be correctily translated in ca.lproj

My specific location is: osascript -e 'user locale of (get system info)' ca_ES

rxhanson commented 1 year ago

Hmm. I'll copy over ca into ca_ES, just like in the other issue (thanks for referencing it).

fv3rdugo commented 1 year ago

If it helps, I do the PR with the ca copy for ca_ES

rxhanson commented 1 year ago

Thanks for looking to do the PR. Closing this one out, but feel free to reopen if you hit any snags.

fv3rdugo commented 1 year ago

I'm sorry, the problems have not been fixed with the new version (Versió 0.61 (67)). Could it be ca_ES instead of ca-ES?, I'm not sure. Left Half, Top Half, Top Left, Last Third, Smaller, Move to the Edge, ...are some examples.

Captura de pantalla 2022-10-29 a les 10 08 46 Captura de pantalla 2022-10-29 a les 10 14 32
rxhanson commented 1 year ago

It was a missing end quote, got it!

Is this identical to what you had prior to v0.61? If so, then we can do away with the additional translation file and just fix the existing "ca" one.

fv3rdugo commented 1 year ago

Yes, you're right, there is a missing end quote, only one. Sorry for the mistake. I think this was the original error, and not the ca_ES locale. Maybe removing it is a the best idea. Thank you for your quick reply.