search

rxi / aria

A tiny, embeddable lisp-shaped language implemented in C89
MIT License
167 stars 18 forks source link

Recommendation: move the UNUSED macro to aria.h #3

Closed jason-c-daniels closed 7 years ago

jason-c-daniels commented 7 years ago

Use Case The consuming developer wishes to embed an aria console in their application, modeled on the sample main function.

Estimated Impact Cons: Potential for human error during copy and paste. Pros: It keeps the coding style neat and consistent with the rest of aria and provides an "out of the box" compilable solution for beginning programmers who want to start extending and embedding aria in another application.

rxi commented 7 years ago

The UNUSED macro is intentionally internal as projects which have unused-variable warnings enabled will likely be using their own unused-macro, those that don't wouldn't require such a macro. I'm not sure I understand the benefit of moving it to the header file.

jason-c-daniels commented 7 years ago

I guess I misunderstood the purpose of that macro. I thought it was more important than it was. :-)