search

rxri / spicetify-extensions

Collection of custom Spicetify extensions to enhance your Spotify experience
MIT License
156 stars 1 forks source link

bug: Shuffle button not working after latest adblock.js commit #18

Closed elidoz closed 3 months ago

elidoz commented 3 months ago

🔍 Is there already an issue for your problem?

ℹ Environment / Computer Info

- Spotify version: 1.2.42.290 from Flathub
- Spicetify version: 2.37.1

📦 Extension name

adblock

📝 Description

To reproduce this error I have to install the adblock.js file from Aug 7, 2024. The shuffle button doesn't change the shuffle state, and I expect it to change between no shuffle, shuffle, and smart shuffle. When the extension is removed I don't observe the bug. A solution I found was reverting to the adblock.js commit from Jul 18, 2024, which fixes all issues for me. Therefore I suspect that this is a problem with the latest commit that should be fixed.

📸 Screenshots

No response

rxri commented 3 months ago

That's not the fault of adblock. It's just a visual bug. I will disable smart shuffle completely anyways.

rxri commented 3 months ago

Resolved with https://github.com/rxri/spicetify-extensions/commit/9ae759120449e3f2431175f7f44ce162da112c92