rxri / spicetify-extensions

Collection of custom Spicetify extensions to enhance your Spotify experience
MIT License
135 stars 1 forks source link

bug: adblockify does not work #21

Closed Criptonized closed 2 months ago

Criptonized commented 2 months ago

🔍 Is there already an issue for your problem?

ℹ Environment / Computer Info

- Spotify version: 1.2.44.405
- Spicetify version: 2.37.4

📦 Extension name

adblockify

📝 Description

ad blocka not working update it pls

📸 Screenshots

image

AnonymousGryffindor commented 2 months ago

image the banner ads and ads between songs have resumed

T0RNATO commented 2 months ago

only now do I realise how insufferable spotify ads are. I would greatly appreciate a fix

rxri commented 2 months ago

Well, that's not really adblock's fault. Marketplace does not inject the extension for 99.99%. What I would recommend is to reinstall spotify, re-apply spicetify while on latest (v2.37.4) with spicetify backup apply and re-installing adblock from marketplace, or installing it locally.

daqnxx commented 2 months ago

same thing started happening to me today, i've tried to reinstall it and all but still not working

rxri commented 2 months ago

image Adblockify works just fine, as it should. When new ad is inserted into the slot, adblockify removes it.


Spotify for Windows (64 bit)
1.2.45.451.gac8a666f
Spicetify vDev
xpui_2024-08-23_1724395464028_ac8a666
cef_127.3.4+ge9e2e14+chromium-127.0.6533.100
Runtime: Chrome
Build System: Bazel
CormacZ commented 2 months ago

Man, it keep giving me ads

rxri commented 2 months ago

If you keep having ads then please follow these instructions:

  1. Make sure you're on v2.37.4 (latest spicetify version)
  2. Please re-apply spicetify (spicetify restore backup apply)
  3. If still doesn't work, remove adblockify from marketplace and add it again
  4. If it doesn't help either, please reinstall spotify (uninstall and install it again)
  5. You can also install adblockify locally, please do so by following instructions at https://github.com/rxri/spicetify-extensions/blob/main/adblock/README.md

If this doesn't work, please post your spotify version:

image image Click on Spicetify v<version> to expand the data and then click the copy button on the right and post it here. Thank you.

If your comment won't have this information, it will be hidden.

Coldmint25 commented 2 months ago

Hello I have already tried all the steps and it still doesn't work here is the version Spotify for Windows (64 bit) 1.2.44.405.g81fd6352 Spicetify v2.37.4 Theme: marketplace Extensions: adblock.js, hidePodcasts.js Custom apps: marketplace, lyrixed

rxri commented 2 months ago

At this point I think something is up with spicetify on 1.2.44. I will look into it later

blindmodz commented 2 months ago

For me wasnt working, reinstalled through marketplace and used spicetify apply on Terminal and started working again

kritaadi commented 2 months ago

this is my version Spotify for Windows (64 bit) 1.2.44.405.g81fd6352 Spicetify v2.37.4 WHEN I DOWNLOADED SPICETIFY one of the line said there "error Extension "adblock.js" not found."

daqnxx commented 2 months ago

Installing extension locally fixed the issue for me

T0RNATO commented 2 months ago

reinstalling in marketplace seems to have resolved this

Nebroc351 commented 2 months ago

I tried the troubleshoot steps but cannot get it to work on 1.2.45, I will try to find an older spotify version to install for now

Spotify  pour Windows (64 bits) 1.2.45.454.gc16ec9f6 Spicetify v2.37.4 Theme: Hazy / Base Extensions: adblock.js, autoSkipVideo.js, loopyLoop.js, shuffle+.js, trashbin.js, beautiful-lyrics.mjs, hidePodcasts.js, QueueTime.js, bookmark.js, songstats.js, writeify.js, quickQueue.js, made-for-you-shortcut.js, spotifyGenres.js, volumePercentage.js, remove-unplayable-songs.js, css-editor.js, hazy.js Custom apps: marketplace, stats, name-that-tune

rxri commented 2 months ago

This is now fixed. Issue existed only when adblockify was installed with marketplace. I have added some stuff that should fix it (and I tested them now and they seem to be working). I also have added automatic fast updates to adblockify so marketplace users, or local users will now use wrapper to get the latest version. Re-install extension from marketplace to get the latest version.

rxri commented 2 months ago

v2.37.5 should fix this issue.

CormacZ commented 2 months ago

Look fine so far