bug: popup ads still appear

[WiLuX-Source]

🔍 Is there already an issue for your problem?

• [X] I have checked older issues, open and closed

ℹ Environment / Computer Info

- Spotify version: 1.2.37.701
- Spicetify version: 2.36.11

📦 Extension name

adblockify

📝 Description

ad banner pops up with ReactModalPortal

📸 Screenshots

No response

[WiLuX-Source]

I will screenshot if I get banner again tomorrow.

[rxri]

Do you have the latest version of Adblock though? You may be cached via jsdelivr because it's not possible since I disable the thing they send these popups by

[WiLuX-Source]

[WiLuX-Source]

I installed through marketplace is there way to check adblock version as well?

[WiLuX-Source]

since I have devtools enabled I checked contents of adblock.js with mine and yours manually, yes they are same.

[rxri]

Did you try restarting your client though and checking if popup still appears?

[WiLuX-Source]

I have most up to date version of your adblocker and the clients specified above. I will keep giving screenshots when it appears again.

[Exinie]

Same issue for me as well.

[rxri]

Sorry, it was my fault. https://github.com/rxri/spicetify-extensions/commit/34130a54cd7a4b1b953cd9c1863232c9f28514e9 should fix it. I cleared jsdelivr cache so it should be available shortly on marketplace as well

[WiLuX-Source]

It will take a while, currently testing it and made sure it is not cached.

[rxri]

Will close in the morning if no one will report this issue in meantime

[WiLuX-Source]

It seems fine for now. Though it would be better to wait at least 1 day before closing this issue.

Thank you for your attention.

[rxri]

Now it will work for 100% because it correctly overrides the exp feature (enableInAppMessages) that handles these popups inside ReactModalPortal. No need to keep this issue opened