search

rxsheep / egistest

0 stars 0 forks source link

De-springify #1

Open moshloop opened 7 years ago

moshloop commented 7 years ago

Can we try and de-springify this solution? i.e favor conciseness and readability over verbosity and abstraction?

rxsheep commented 7 years ago

Hello Moshe, Do you think that my factory implementation is too complex or the class heirarchy?

moshloop commented 7 years ago

A little of both - The problem is pretty simple, it really shouldn't require any design patterns or many classes.

On Tue, May 16, 2017 10:29 AM, rxsheep notifications@github.com wrote: Hello Moshe, Do you think that my factory implementation is too complex or the class heirarchy?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Moshe Immerman Technical Director moshe@egis-software.com Egis Software |
www.papertrail.co.za 011 880 4411​ ​|0724821895​ Find us on a map How did I do?

Click on a face to provide feedback on my performance!

rxsheep commented 7 years ago

it's pretty funny you should say that, I have failed coding tests in the past for coding the simplest solution and found that the usual expectation is that you write in some design pattern, use an interface, segregate functional code, and make it as enterprise'y as possible before they consider it.

Most of those companies would have thrown this submission out purely on the lack of unit tests, but based on the interview i figured that's not something that would have bothered you.

moshloop commented 7 years ago

Yeh, we definitely are very anti enterprise'y around here. And correct -  the lack of unit tests don't bother me.

On Tue, May 16, 2017 10:45 AM, rxsheep notifications@github.com wrote: it's pretty funny you should say that, I have failed coding tests in the past for coding the simplest solution and found that the usual expectation is that you write in some design pattern, use an interface, segregate functional code, and make it as enterprise'y as possible before they consider it.

Most of those companies would have thrown this submission out purely on the lack of unit tests, but based on the interview i figured that's not something that would have bothered you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Moshe Immerman Technical Director moshe@egis-software.com Egis Software |
www.papertrail.co.za 011 880 4411​ ​|0724821895​ Find us on a map How did I do?

Click on a face to provide feedback on my performance!