ry85 / VAE-GAN

Pytorch implementation of paper "Autoencoding beyond pixels using a learned similarity metric"
41 stars 15 forks source link

Reconstruction Loss Not Included #3

Closed GloryyrolG closed 3 years ago

GloryyrolG commented 3 years ago

Hi,

I believe recons loss should be part of ELBO, however not used in the repo.

https://github.com/ry85/VAE-GAN/blob/cd4a9f5236731eb20257f7a54eb3389f654094bf/network.py#L228

GloryyrolG commented 3 years ago

Finally, I found in Section 2.3 of the original paper, the author said,

Specifically, since element-wise reconstruction errors are not adequate for images and other signals with invariances, we propose replacing the VAE reconstruction (expected log likelihood) error term from Eq. 3 with a reconstruction error expressed in the GAN discriminator.

The implementation is correct.