Added digit, number, whitespace, one_or_more, and zero_or_more methods

JSchaenzle commented 11 years ago

I added digit, number, whitespace, one_or_more, and zero_or_more methods. I also updated rspec tests as well.

ryan-endacott commented 11 years ago

Thanks! I like it. A few minor things:

I'd prefer that you use single quoted strings, as it makes the regex meaning a little more clear because you don't have to escape the backslash. Ex: '\w+' == "\\w+"
I think that you should change number to integer, because people may think that number matches something like 1.35
Please change the groups for zero_or_more and one_or_more to be noncapturing so they don't affect the existing groups API.
Just a note, we may want to consider using multiple for one_or_more and zero_or_more like discussed in this implementation issue. For now, I think that zero_or_more and one_or_more are fine though.

Thanks a ton! Make the minor changes and it'll be good to merge.

JSchaenzle commented 11 years ago

I agree. All good thoughts. I made the change. Thanks!

ryan-endacott commented 11 years ago

Thanks! :+1:

ryan-endacott / verbal_expressions