Closed JSchaenzle closed 11 years ago
Thanks! I like it. A few minor things:
'\w+' == "\\w+"
number
to integer
, because people may think that number
matches something like 1.35
zero_or_more
and one_or_more
to be noncapturing so they don't affect the existing groups API. multiple
for one_or_more
and zero_or_more
like discussed in this implementation issue. For now, I think that zero_or_more
and one_or_more
are fine though.Thanks a ton! Make the minor changes and it'll be good to merge.
I agree. All good thoughts. I made the change. Thanks!
Thanks! :+1:
I added digit, number, whitespace, one_or_more, and zero_or_more methods. I also updated rspec tests as well.