search

ryan-lang / homeassistant-davis-local

Provides an all-local polling integration for Davis Instruments devices, including WeatherLink and AirLink.
3 stars 0 forks source link

Just saying hi #1

Closed siku2 closed 1 year ago

siku2 commented 1 year ago

This would've been better suited as a discussion, but since they aren't enabled on this repository (at the time of writing) I'm creating this issue instead.

I just randomly stumbled upon your repository and was wondering whether you're aware of the project I started back in 2021, which is doing the same thing as yours: https://github.com/siku2/hass-weatherlink

The integration has aged a bit as there have been a lot of changes in Home Assistant and I'm planning on doing a major overhaul in the coming days, so I'm here because I want to see what we can learn from each other.

One thing you might be interested in is the WeatherLink Broadcast API implementation, which allows the Home Assistant instance to passively receive information from the weatherlink / airlink devices with a much higher frequency than would be possible using polling.

I'm excited to see that you've started to implement AQI calculation. That's something that I've wanted to add back then, but never got to. Can you tell me where you're getting the parameters for the calculation from?

siku2 commented 1 year ago

Oh and another thing that might interest you is that you can discover weatherlink and airlink devices in the network using zeroconf.

ryan-lang commented 1 year ago

Hi there, thanks for reaching out! As you can maybe tell, my implementation is just a quick & dirty approach to get something working over the weekend. I'm not sure how I missed yours, but seems like it could have saved me some effort! I'd be happy to redirect my future efforts towards your project, so we can converge on a single feature set.

To that end, I'll answer your question about AQI in the existing discussion on your repo.

Generally, do you have a roadmap for your overhaul? Maybe it'd be most useful for me to wait and see what that looks like before contributing anything?

siku2 commented 1 year ago

Generally, do you have a roadmap for your overhaul? Maybe it'd be most useful for me to wait and see what that looks like before contributing anything?

I'm hoping to get it done by the end of the week. Since this will basically be a full rewrite I think you might want to hold back with any major contributions until then. However, if you have more ideas that I should be taking into consideration while working on it, do let me know!