ryan-roemer / django-cloud-browser

Django application browser for cloud datastores (Rackspace, AWS, etc.).
http://ryan-roemer.github.com/django-cloud-browser/
MIT License
81 stars 27 forks source link

Updated for django 1.10 and Python3 #11

Closed rmad17 closed 6 years ago

rmad17 commented 7 years ago

I updated the code to add support for python3 and made changes to work with django 1.10 as well. Tested with python 2.

ryan-roemer commented 7 years ago

Thanks for the update! Can you

Thanks!

rmad17 commented 7 years ago

Hey @ryan-roemer . I removed two unused variables. Now PyLint is warning about a builtin called filter. I did some searching and most people recommend ignoring the warning. Can you tell me what I need to do to fix the linting error. Also what did you mean by Add a "good" python3 version to "2.7" so we run both in Travis CI? Sorry I did not understand.

ryan-roemer commented 7 years ago

@rmad17 -- Not sure about filter. You can ignore it if you also provide an online link to it being spurious.

For travis, I mean switch this:

python:
  - "2.7"

to add a python3 version that is a good one to test (I don't use py3 right now), so:

python:
  - "2.7"
  - "3.PICK_A_VERSION_HERE"
aidanrussell commented 7 years ago

Can this be fixed? Currently package not compatible with Python 3. For a version then 3.6 is the latest.

ryan-roemer commented 7 years ago

@aidanrussell -- If you can open a new PR using @aidanrussell 's fine work as a start and my comment guidance to get CI passing for both Python 2 and 3, I'll merge and release. Thanks!

ryan-roemer commented 6 years ago

Superseded by #14