search

ryan-roemer / django-cloud-browser

Django application browser for cloud datastores (Rackspace, AWS, etc.).
http://ryan-roemer.github.com/django-cloud-browser/
MIT License
81 stars 27 forks source link

Modified to support Django 1.5+ #5

Closed jthompsonsmi closed 10 years ago

jthompsonsmi commented 10 years ago

Very minor API changes.

ryan-roemer commented 10 years ago

@jthompsonsmi -- Thanks for the work! However, I think there's still some further changes needed. Running fab pylint gives the following errors, which I've honed down to a relevant list for this PR:

************* Module cloud_browser.urls_admin
E0611:  2,0: No name 'defaults' in module 'django.conf.urls'
F0401:  2,0: Unable to import 'django.conf.urls.defaults'
************* Module cloud_browser_project.manage
E0611:  2,0: No name 'execute_manager' in module 'django.core.management'
************* Module cloud_browser_project.urls
E0611:  2,0: No name 'defaults' in module 'django.conf.urls'
F0401:  2,0: Unable to import 'django.conf.urls.defaults'
E0611:  3,0: No name 'defaults' in module 'django.conf.urls'
F0401:  3,0: Unable to import 'django.conf.urls.defaults'
E0611:  6,0: No name 'simple' in module 'django.views.generic'
F0401:  6,0: Unable to import 'django.views.generic.simple'

And running fab run_server and navigating to http://127.0.0.1:8000/cb/browser/, I get:

screen shot 2014-06-18 at 8 27 13 am

ryan-roemer commented 10 years ago

And I've now fixed master branch to correctly pass fab pylint against the current requirements file.

boscoMW commented 10 years ago

okay, so when will this be merged, i don't see anything wrong with the pull request.

ryan-roemer commented 10 years ago

@Mbosco -- Once the PR passes fab pylint I will substantively look at it. Right now it's failing the following in this branch with Django 1.5:

************* Module fabfile
W0611:  5,0: Unused import urllib
************* Module cloud_browser.urls
E1120:  8,15: No value passed for parameter 'cls' in function call
W0611:  2,0: Unused import include
************* Module cloud_browser.urls_admin
C0301:  8,0: Line too long (81/80)
E0611:  2,0: No name 'defaults' in module 'django.conf.urls'
F0401:  2,0: Unable to import 'django.conf.urls.defaults'
E1120:  8,15: No value passed for parameter 'cls' in function call
************* Module cloud_browser.cloud.aws
F0401: 31,8:AwsObject.is_key: Unable to import 'boto.s3.key'
F0401: 39,8:AwsObject.is_prefix: Unable to import 'boto.s3.prefix'
************* Module cloud_browser.cloud.boto_base
F0401: 35,8:BotoExceptionWrapper.translate: Unable to import 'boto.exception'
************* Module cloud_browser.cloud.google
F0401: 50,8:GsObject.is_key: Unable to import 'boto.gs.key'
F0401: 62,8:GsObject.is_prefix: Unable to import 'boto.s3.prefix'
************* Module cloud_browser_project.manage
E0611:  2,0: No name 'execute_manager' in module 'django.core.management'
************* Module cloud_browser_project.urls
E0611:  2,0: No name 'defaults' in module 'django.conf.urls'
F0401:  2,0: Unable to import 'django.conf.urls.defaults'
E0611:  3,0: No name 'defaults' in module 'django.conf.urls'
F0401:  3,0: Unable to import 'django.conf.urls.defaults'
E0611:  6,0: No name 'simple' in module 'django.views.generic'
F0401:  6,0: Unable to import 'django.views.generic.simple'
ryan-roemer commented 10 years ago

Fixed in other PR #6