Support for bootstrap 4?

ryan-roemer / sphinx-bootstrap-theme

Sphinx Bootstrap Theme

http://ryan-roemer.github.io/sphinx-bootstrap-theme/README.html

MIT License

586 stars 206 forks source link

Support for bootstrap 4? #146

Open hsingh23 opened 8 years ago

hsingh23 commented 8 years ago

What's the roadmap for supporting bootstrap 4?

ryan-roemer commented 8 years ago

For me personally, supporting existing 2 / 3 is my main priority unless I get a huge chunk of free time for this project...

If someone can take the lead on getting a bootstrap4 port going, I'll definitely take and help support / work out the kinks of a pull request!

svenevs commented 6 years ago

If anybody is interested in getting started with this, the TODO.html page shows what is needed as far as embedding the actual bootstrap / bootswatch resources go.

Unfortunately, it is unlikely that simply enabling bootstrap 4 is going to work out. Ideally, somebody familiar with the actual bootstrap internals / incompatibilities would chime in here

ryan-roemer commented 6 years ago

I would welcome a PR for BS4. And it may be worth considering just semver majoring this library to v1.0.0 with only BS4 support.

While I don't have a ton of time for this, I can help with any JavaScript-related hurdles or issues as that's what I do for my day job, and have a very good familiarity with all that arcana...

svenevs commented 6 years ago

Bumping major and committing to bs4 makes a lot of sense. I've been slowly learning of the new bs4 stuff, and I think the amount of changes that need to happen are too unwieldy to try and make 2/3/4 compatible code. My understanding is we need to fully switch to "cards" for most of this.

artob commented 6 years ago

Looks like there's an independent Sphinx on Bootstrap 4 effort at myyasuda/sphinxbootstrap4theme (demo)

nbara commented 4 years ago

FWIW Bootstrap 5 (alpha) has now been released: https://v5.getbootstrap.com/

More info here: https://blog.getbootstrap.com/2020/06/16/bootstrap-5-alpha/