ryan-txn / pe

0 stars 0 forks source link

Error in Handling Invalid dates #4

Open ryan-txn opened 2 weeks ago

ryan-txn commented 2 weeks ago

image.png The program is able to detect invalid dates, however it does not flag these values as errors. Instead it only flags errors when the date is >31, and anything from more than the number of dates in the month to 31 is autocorrected.

nus-pe-script commented 1 week ago

Team's Response

Thank you for bringing this to our attention. We acknowledge that accepting errornous date inputs results in unexpected behaviour, and that error messages should be thrown in these cases.

However, we feel that this issue has low severity (rather than medium) for the reason that both the likelihood and scope of this error is relatively small in view of regular usage (Only occurs on a couple of specific date inputs each year). As such, we don't believe it could be expected to affect "some" users as more than a "minor inconveniece" per the reporting guide, given that users also have access to reminder deletion/adding functionality that allows them to correct these inputs, and the reminder information is immediately presented to them to confirm.

This is as opposed to if this error was present in the add command, where a substantial amount of user input/data is stored in the created object and thus editing poses a non-minor inconvience.

Additionally, as this behaviour falls within the scope of our advertised functionality, but is unexpected, we also believe this to be a FuntionalityBug rather than a FeatureFlaw.

We appreciate your help in making our program more resilient and user friendly.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]