Added non-ascii support for emails subjects (view)

ryanb / letter_opener

Preview mail in the browser instead of sending.

MIT License

3.71k stars 236 forks source link

Added non-ascii support for emails subjects (view) #133

Closed arkirchner closed 7 years ago

arkirchner commented 7 years ago

Email subjects can be encoded to support addidonal characters. This changes add decoding support to show the subject in UTF-8

Example subject ('ISO-2022-JP' encoded)

Encoded: =?ISO-2022-JP?B?GyRCRnxLXCROPGdCahsoQg==?= Decoded: 日本の主題

arkirchner commented 7 years ago

Can I do something to get this approved? Is there a reason to keep the decoded header?

Thank you very much for the help m( )m

nashby commented 7 years ago

@arkirchner hey! Thank you for the pull request. Would you mind adding spec for that? Thanks!

arkirchner commented 7 years ago

@nashby sorry for the late replay. I changed the implementation and wrote tests. It turned out that I didn't need to use "toutf8" in the test environment. I will make further tests with the rails app in my company.

I don't think it is a problem with letter_opener. So I close this pull request for now.

Thank you very much for your time.

nashby commented 7 years ago

Oh I see. @arkirchner no problem! Feel free to reopen it if you find out the issue with your app!