search

ryanb / letter_opener

Preview mail in the browser instead of sending.
MIT License
3.73k stars 237 forks source link

Rails 5.x Support #141

Closed lucianosousa closed 7 years ago

lucianosousa commented 7 years ago

Do you guys have plans to update the gem to be compatibe with Rails 5 series?

nashby commented 7 years ago

@lucianosousa do you have any particular issues with Rails 5? Can you please describe what's wrong? And it would be nice if you could push some sample application that fails so we can dig into it!

lucianosousa commented 7 years ago

@nashby I'ts in a private repo. But, the problem is that any email is rendered to me here. Do you know if the gem is compatible with rails5? I can take a look on this weekend to see what can we do reproduce here

nashby commented 7 years ago

@lucianosousa nope, I don't use it with Rails 5 ATM. So please feel free to send sample application that reproduces your issue and we fix it together!

nisshiee commented 7 years ago

In my project, letter_opener runs with rails 5.0.1 but occurs error with rails 5.0.2.

This error is my mistake - invalid git merging Gemfile.lock. So please ignore me.

nisshiee commented 7 years ago

Sorry, this simple test application works correctly... https://github.com/nisshiee/letter_opener_test

lucianosousa commented 7 years ago

sorry being late guys. Yes, I did few tests here again and seems everything works correct