search

ryanb / letter_opener

Preview mail in the browser instead of sending.
MIT License
3.71k stars 236 forks source link

Add disable_mail_validation option to configuration #163

Closed favrik closed 5 years ago

favrik commented 5 years ago

Hi!,

thank you for letter_opener!! :)

this is a WIP PR, just want to know if this is the right approach.

We have a codebase that is currently using 1.4.1, I was wondering if there was a way to get only the HTML from the mail (without metadata), and found that the latest version already had the option for a "light" template!

However, it also adds validation for the smtp_envelope_from and smtp_envelope_to values. Something that the old version was doing in a different way, and it wasn't preventing the email preview, but the latest version does prevent it. Hence this PR.

Thanks!

nashby commented 5 years ago

@favrik hey! Thanks for pull request. Can you please share your use-case when you want to send an email without from and to addresses?

nashby commented 5 years ago

@favrik hey! I'm gonna close this one for now but feel free to ping me with a use-case and I'll reopen it.