search

ryanb / letter_opener

Preview mail in the browser instead of sending.
MIT License
3.71k stars 236 forks source link

Fix bug where all japanese characters are converted to underscores in the file name #175

Closed ihatov08 closed 2 years ago

ihatov08 commented 4 years ago

before

attachment file name is "候補者_xxxx.csv"

All Japanese characters in file names are converted to underscores like ____xxx.csv.

Screenshot from 2020-03-18 13-59-08

after

Fixed so that Japanese characters in file names are not converted to underscores using urlencode

Screenshot from 2020-03-18 13-58-31

nashby commented 2 years ago

@ihatov08 thanks for the PR! I went with a bit different approach but in the end it fixes this issue. Thanks for reporting!