ryanb / nested_form

Rails plugin to conveniently handle multiple models in a single form.
MIT License
1.79k stars 505 forks source link

Link to remove not working as expected when :nested_wrapper is false #379

Open hurrycaner opened 7 years ago

hurrycaner commented 7 years ago

When we set :nested_wrapper to false, the

is not created...

https://github.com/ryanb/nested_form/blob/1b0689dfb4d230ceabd278eba159fcb02f23c68a/vendor/assets/javascripts/jquery_nested_form.js#L76

The removeFields function should consider this when hiding triggering the nested:fieldRemoved event. Also, some documentation about :nested_wrapper => false should be added too... probably with instructions saying that when nested_wrapper is false, you must hide content by yourself or something like that...

cesc1989 commented 5 years ago

@hurrycaner man, I stumbled across this one today. Sadly this repo is no longer being maintained. Going to fork it and try to come out with a solution to this :smile: