exception handling and channel parsing

ryanb / private_pub

Handle pub/sub messaging through private channels in Rails using Faye.

MIT License

863 stars 226 forks source link

Closed zubin closed 13 years ago

zubin commented 13 years ago

Hi Ryan

I've added the following, with tests:

custom exception when server connection refused (helper rescues, failing silently for now)
helpers now accept passing in objects, so you can do suscribe_to(@page)
basic channel validation (initially, I didn't realise they had to start with a /)

Perhaps the helper should output the requested javascript, so at least it runs on the originator's machine, but that option requires more thought.

Zubin

ryanb commented 13 years ago

It looks like this is the same pull request you gave in issue #13. I addressed the issues there.

garrettlancaster commented 12 years ago

+1 for channel validation, I've been struggling for a while with channel names sans /