search

ryanb / private_pub

Handle pub/sub messaging through private channels in Rails using Faye.
MIT License
864 stars 228 forks source link

Support for https #33

Closed vanne closed 12 years ago

vanne commented 12 years ago

I made the needed changes so messages can be published to HTTPS and documented (in the readme) how to run Thin so it serves HTTPS instead of HTTP. Thought this is worth sharing.

zlu commented 12 years ago

I'd love to see this pull request being accepted!

mrrooijen commented 12 years ago

/subscribe

4ware commented 12 years ago

Hey ryan. Please pull this in. It's the only thing stoping me from using this in my production environment.

zlu commented 12 years ago

I have used the fork from @vanne. Currently my thin server dies with this error:

ruby: ssl.cpp:162: SslContext_t::SslContext_t(bool, const std::string&, const std::string&): Assertion `e > 0' failed. Aborted

I'm using a pem file that contains intermediate certs (3 certs total). Not sure if anyone knows about how to fix this.

ryanb commented 12 years ago

Thanks for working on this @vanne.

@zlu, please let me know if you figure out this issue and if there is something that can be updated in Private Pub to fix it.

zlu commented 12 years ago

@ryanb Thanks for merging it. I have figured out the issue on my end and can verify that ssl is indeed working. The code works fine as it is but may need some extra documentation which I plan to supply soon.

nfm commented 12 years ago

For anyone else that comes across this issue, please note that the changes in this merge have not been released. The current published version of private_pub is 1.0.1, which doesn't include support for HTTPS.

You'll need to add the gem to your Gemfile with a git reference, like so:

gem 'private_pub', git: 'git://github.com/ryanb/private_pub.git', ref: '157daa14dbdf30fe5911998989e24e9aac96133f'

@ryanb would it be possible to do a 1.1.0 release of private_pub? I noticed you're not working on the project actively - let me know if I can help out at all, as I'd like to see this released.