search

ryanb / private_pub

Handle pub/sub messaging through private channels in Rails using Faye.
MIT License
864 stars 228 forks source link

It doesn't work in IE8 #57

Closed ndan closed 3 years ago

ndan commented 12 years ago

This looks like a really useful tool, unfortunately it doesn't seem to be working in IE8.

bchase commented 12 years ago

It seems that the WebSocket protocol is not going to be supported until Internet Explorer 10.

gmanley commented 12 years ago

This tool isn't really adding any functionality that would be effected by the browser. If you are going to open a ticket it should probably be here: https://github.com/faye/faye. Also faye doesn't just use websockets, if there isn't websocket support in the browser it falls back to long-polling. You should also be a bit more specific about what isn't working.

ndan commented 12 years ago

No, Faye supports: ie7+ The real problem was in the element.onload We fix this problem: https://github.com/ascrazy/private_pub/commit/5bcfb4fc66eae61ca74ea710c6cf98cb69c40207

madsheep commented 11 years ago

any updates on that?

clemens commented 11 years ago

I can confirm that the solution provided in https://github.com/ascrazy/private_pub/commit/5bcfb4fc66eae61ca74ea710c6cf98cb69c40207 works. Why is there no pull request for that (@ndan)?

clemens commented 11 years ago

Any updates?

ndan commented 11 years ago

https://github.com/ryanb/private_pub/pull/61