search

ryanb / private_pub

Handle pub/sub messaging through private channels in Rails using Faye.
MIT License
864 stars 228 forks source link

add ie8 support #61

Open ascrazy opened 11 years ago

nfm commented 11 years ago

Hi @dbanck, the Microsoft KB article (http://support.microsoft.com/kb/927917) seems to say it's an IE7 issue - are you able to confirm whether you've had the same error for IE8?

Unfortunately we can't move the appendChild into onload - appending the script is what makes it start loading in the first place. I'm looking into the jQuery pattern of handling this, which I believe is to avoid the bug you've reported - they use document.head.insertBefore(script, document.head.firstChild) instead.

I will check back soon with some more information about this pull request once I've done my homework!

JohnAmican commented 11 years ago

Is this still active?

wakiki commented 11 years ago

I confirm it's still not working in IE7, and I'm getting this error:

HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)

IE8 works fine.

Is there any progress on fixing this for IE6/7 (I know we shouldn't support these old browsers, but we have no choice... sigh)

davidlesches commented 10 years ago

I was having the parse error with IE8, I corrected it using this - http://www.jspatterns.com/the-ridiculous-case-of-adding-a-script-element/

i.e. I replaced doc.documentElement.appendChild(script); with

var first = document.getElementsByTagName('script')[0];
first.parentNode.insertBefore(script, first);