ryanb / private_pub

Handle pub/sub messaging through private channels in Rails using Faye.
MIT License
863 stars 226 forks source link

Allow environment variables in the configuration file #75

Open IamNaN opened 11 years ago

IamNaN commented 11 years ago

This eases deployment by allowing environment variables in private_pub.yml.

Because Faye needs to run in production mode, the yaml file's production block gets used for both development and production, making private_pub hard to deploy.

production:
  server: <%= ENV["FAYE_SERVER"] %>
  secret_token: <%= ENV["FAYE_KEY"] %>

This change also forces signature_expiration to an integer regardless of how it is entered in the configuration, and it adds tests.

IamNaN commented 11 years ago

Also, I required yaml in private_pub.rb because tests weren't passing without it, even before this pull request.

rubytastic commented 11 years ago

This would have been interesting, How about Puma? what is needed to get puma to work with private_pub,

Changing adapter to puma still gives a

19:39:24 privpub.1 | /Users/Jordan/.rvm/gems/ruby-2.0.0-head@books/gems/rack-1.5.2/lib/rack/handler/thin.rb:1:in `require': cannot load such file -- thin (LoadError)

Where/ How to overrule this?

gakshay commented 9 years ago

@ryanb How about merging this pull request. Having a similar need to use the Environment variables on production..

ferydjzz commented 7 years ago

+1 I also need to use ENV['variable'] on production