search

ryanb / private_pub

Handle pub/sub messaging through private channels in Rails using Faye.
MIT License
864 stars 228 forks source link

collaboration on updating this gem? #88

Closed rubytastic closed 10 years ago

rubytastic commented 10 years ago

This gem has been a bit outdated by Ryan for quite some time now, Is anyone interested with myself, in forking this and upgrading + applying the pending forks ?

@ryanb would you find it ok, if we fork this project and make it up2date again?

gregmolnar commented 10 years ago

I emailed @ryanb about this but haven't got a reply. I guess he is still taking his time off. I don't think he would have any issue if someone forks it and maintains the project. I use this gem at my projects and would help to maintain if you fork it. Or I can fork it and we can work on that fork.

rubytastic commented 10 years ago

@gregmolnar: Would be great I could reserve a day for it this week since really need this code updated for existing project. I make a fork for it, let's discuss how to organise the work to be done. What are your thoughts?

gregmolnar commented 10 years ago

Sounds good to me. I will try to make some time free too this week to fix the most important issues.

rubytastic commented 10 years ago

Fork is here: https://github.com/rubytastic/private_pub

I start working on it tomorrow

rubytastic commented 10 years ago

@gregmolnar I decided to drop this code and go for SSE in rails 4, thread save cleaner and solving some demonising issues for me all in 1 go.

gregmolnar commented 10 years ago

How does it perform to you? I was thinking about to use that when I decided to go with faye but my understanding is with SSE all you clients need a worker to run on the server side which sounds like a huge waste of resources. But I might be wrong.

rubytastic commented 10 years ago

@gregmolnar It can do the same as private pub out of the box just need to do some research on how to make a "private" channel, im working on it now much cleaner solution I would go for. Only internet exploder browser on Winblows are not supported but there are workarounds for that.