ryanb / ruby-warrior

Game written in Ruby for learning Ruby.
MIT License
3.83k stars 838 forks source link

Make runnable in Ruby 3.3 #101

Closed fpsvogel closed 3 months ago

fpsvogel commented 3 months ago

Summary

Specs are out of scope

I haven't similarly brought the specs up to date because that would make for a massive PR, requiring an upgrade to RSpec 3 with all its syntax changes. So I limited this PR to making it possible to run rubywarrior without errors or warnings.

Screenshots

Here are the specific errors and warnings that this PR addresses.

Addressed in https://github.com/ryanb/ruby-warrior/commit/6dd5667da0d4fd8ae90e99f5087794e231aba3fd:

require-error

Addressed in https://github.com/ryanb/ruby-warrior/commit/94d73b55ccbf3d90e57f172974d1f915f8b58436:

File-exists-error

Addressed in https://github.com/ryanb/ruby-warrior/commit/a5ae961ae5b4f4771e93ba9eb42dceadd4da6d0c:

ERB-new-warning