search

ryanb / ruby-warrior

Game written in Ruby for learning Ruby.
MIT License
3.83k stars 838 forks source link

Rspec and Cucumber Fixes #43

Closed jameskbride closed 12 years ago

jameskbride commented 12 years ago

Hi, I checked out your code and attempted to run all of the tests, but it looks like there was a problem in the require statements. Rspec automatically adds the /spec directory to the path, so '''require File.dirname(FILE) + '/../spec_helper'''' is actually unnecessary. Replacing that line with '''require 'spec_helper'''' corrects the issue.

I also fixed the warnings in the cucumber scripts stemming from the use of Given/When/Then in the step definitions, and updated the .gitignore file for Eclipse integration.

Your project looks fun, I'm looking forward to creating a player and adding my AI logic :-)

gbataille commented 12 years ago

See there, should solve the rspec bit https://github.com/ryanb/ruby-warrior/pull/52

In fact realized you might have fixed it without moving to the new RSpec. I'll leave my pull request still, looks better with the later RSpec I guess