search

ryanb / ruby-warrior

Game written in Ruby for learning Ruby.
MIT License
3.83k stars 838 forks source link

Fix tests #78

Closed rheber closed 3 months ago

rheber commented 9 years ago

Out of the box, five of the tests failed and rspec warned me that the "should" syntax is deprecated. I converted the failing tests to use the "expect" syntax and they passed. Was this only an issue for me? Does the inconsistency warrant the rest of the tests to be converted?

dcki commented 8 years ago

Please see https://github.com/ryanb/ruby-warrior/pull/91. I should have looked for other pull requests like this one first.