ryanbateman / bvg-sensor

A HomeAssistant / HACS integration of Berlin Public Transport (BVG)
The Unlicense
14 stars 1 forks source link

fix: major cleanup of template left-overs and bvg v6 API update #10

Closed ndom91 closed 6 months ago

ndom91 commented 1 year ago

So I initially took a look at this because I noticed it was still asking me for username/password when setting up the integration, which aren't needed here obviously. Then I noticed the sensor couldn't update anymore for some reason, and it turns out theres a newer (non-deprecated) version of this API available.

So the changes I made here include:

My final question to you is, are the binary_sensor and switch entites necessary? What are they used for? To me it looks like they are unused, can we remove them and simplify this? I think the bvg-sensor integration should just provide sensors for the status of public transit stops you want to follow, right?

Todo

wrapper commented 9 months ago

Hey just wanted to check if there was any plans to merge / finish this? Thanks cc @ryanbateman