Create minimal verison without facial recognition

ryanbateman / vision-bot

A Hubot script for query Google's Vision API and providing an interesting response

13 stars 2 forks source link

Create minimal verison without facial recognition #2

Open pangolingo opened 8 years ago

pangolingo commented 8 years ago

I'm lazy and didn't want to set up an S3 bucket or configure the Heroku buildpack.

Can I suggest a "vision-without-facial.coffee" file that doesn't include the facial recognition stuff? Or possible a feature flag that you could set with an environment variable?

ryanbateman commented 8 years ago

Yes, it's something I'd like to do as well. It may be as simple as not doing the additional steps if you've not set up the S3 config, but that'd still include an additional library, I suppose. Would that additional requirement, that you don't necessarily actually use, be an issue for you?

pangolingo commented 8 years ago

Yes that makes sense rather than maintaining two files. Myself, I just commented out the S3, canvas, and faceAnnotations stuff.

Jaglag commented 8 years ago

++ for minimal version! would be nice to have