search

ryanbinns / ttwatch

Linux TomTom GPS Watch Utilities
MIT License
207 stars 66 forks source link

Preliminary fix for supporting file version 10 #134

Closed derickr closed 6 years ago

derickr commented 6 years ago

Fixes #133

mipapo commented 6 years ago

But seems not to be backward compatibility

derickr commented 6 years ago

@mipapo - I tried with my older Runs, and they worked.

It would be really helpful if you could expand on "it doesn't work", by providing a file, what you've tried, what the outcome was, and what you expeced.

cheers, Derick

mipapo commented 6 years ago

Cannot be converted to tcx - It worked before, but I don't which version of ttwatch I had be running Running (2).ttbin.zip

mipapo commented 6 years ago

Works perfectly!

ryanbinns commented 6 years ago

Thanks very much for investigating this. The code looks fine, but there are a couple of minor aesthetic things I'd like fixed before I merge. There are a couple lines that use tab indentation instead of spaces; please replace with spaces. Also please put opening braces on a new line instead of the end of the line, to match the existing code. After that, I'll be happy to merge.

derickr commented 6 years ago

Sure, will have a look at that. I also still need to test ttbinmod, as it should be able to re-create the right version'ed files after modification.

scubajorgen commented 6 years ago

Fyi: the new TomTom Fitnesspoints seem to be present in the record with tag 0x4A:

  1. Tag 0x4A (1 byte)
  2. Timestamp (epoch seconds) (4 bytes)
  3. Fitness point counter (2 bytes)
  4. Fitness point counter (2 bytes) (The 0x4B record is the new variable length record.)
derickr commented 6 years ago

@scubajorgen Happy to go look at that, and I also still need to fix the writing. Feel free to make a new issue and assign it to me? :-) (If @ryanbinns is OK with that)