search

ryanbinns / ttwatch

Linux TomTom GPS Watch Utilities
MIT License
205 stars 66 forks source link

Merge ttblue repository into ttwatch #170

Open Grimler91 opened 4 years ago

Grimler91 commented 4 years ago

Ping @dlenski.

As TomTom has, regrettably, stopped producing watches we will most likely not see a lot of additional development when it comes to ttwatch and ttblue.

It would be nice to gather all the gathered knowledge about the watches and how they behave in one repository, to better preserve it for the future. In this pull request I have added all the ttblue commits to a subfolder ttblue in the ttwatch repository (using the technique outlined in https://stackoverflow.com/a/6442034), this keeps the git history of both repositories intact.

I have added a -Dttblue=on (on per default) option to ttwatch's CMakeLists.txt, if a user do not want to build ttblue they can hence configure ttwatch with cmake -Dttblue=off . Another important note is that ttblue and ttwatch uses different licenses (GPL and MIT), so combining files from the two projects would not be possible unless one project is re-licensed (I think that is how it works).

Merging ttwatch and ttblue has previously been discussed in https://github.com/ryanbinns/ttwatch/issues/35.

So, @dlenski, @ryanbinns, what do you think of this?

dlenski commented 4 years ago

So, @dlenski, @ryanbinns, what do you think of this?

I don't have a strong preference, honestly, but happy to see them merged if desired. The coding style I used in ttblue is a bit different from ttwatch.