search

ryanblenis / MeshCentral-RoutePlus

Port routing plugin for the MeshCentral project
Apache License 2.0
30 stars 5 forks source link

Disconnects when click on RoutePlus RDP and page refresh #9

Closed uldiseihenbergs closed 4 years ago

uldiseihenbergs commented 4 years ago

i'm crossposting from here: https://github.com/Ylianst/MeshCentral/issues/1156 when i click on RoutePlus RDP on devices page, download starts, but web page says Disconected: image image

and one more thing - when you add or remove port mapping, and then open up a device, "RoutePlus RDP" is not ther or still in place according you add or remove - when you do a full page refresh with Ctrl+Shift+R, then it appers/disappears accordingly. i think, it should work without full refresh.

and i'm on Ubuntu desktop with Google Chrome browser. MC version 0.5.7. and yes, error occurs every time, i just tested again.

ryanblenis commented 4 years ago

I couldn't recreate it with Chrome - but looking at your screenshot actually has the Firefox logo, which I can re-create the issue with. Working on this now. Thanks for the report.

ryanblenis commented 4 years ago

The RDP download issue and "RoutePlus RDP" link display issues have been fixed in v0.1.3

Thank you.

uldiseihenbergs commented 4 years ago

@ryanblenis thanks for your work, but i can't upgrade your plugin - it says it's incompatible with MC, but i'm on MC stable - 0.5.7 know..

ryanblenis commented 4 years ago

0.5.4 - 0.5.8 broke the plugin system version compatibility detection because of the change to the version numbers not having the -alpha_char at the end. This has been fixed in later versions. Once you upgrade MeshCentral you'll be able to upgrade the plugin.

uldiseihenbergs commented 4 years ago

maybe it's time to ask Ylianst to mark new version as stable?

ryanblenis commented 4 years ago

Yeah, given the new versioning changes and stable / latest tags, I'm not sure that he's quite separated channels out of the master branch for stable (bug fixes) and non-stable (feature addition) releases yet- so I'm not sure those tags will carry much weight until that happens.

uldiseihenbergs commented 4 years ago

that's true, i think branch is one. can you ask him to mark new stable version because of this version thing?

ryanblenis commented 4 years ago

MC stable version has been bumped.