search

ryanbr / fanboy-adblock

335 stars 57 forks source link

MSI.com - Required user action blocked again (Fanboy's Annoyance List + Fanboy's Cookie List) #482

Closed THEtomaso closed 6 years ago

THEtomaso commented 6 years ago

Affected site:

https://www.msi.com/

Example:

https://www.msi.com/Motherboard/support/Z170A-PC-MATE.html#down-bios

Issue:

Required user action (cookie consent) is blocked, preventing downloading of files.

Problem filters:

Problem rule:

###ccc-notify

Possible fix:

msi.com#@##ccc-notify

--

Reference (previous issue):

https://github.com/ryanbr/fanboy-adblock/issues/475/

ryanbr commented 6 years ago

I clicked on the red down arrow, came up with a popup (which showed), pressed okay, and then it downloaded a file. Seems okay?

ryanbr commented 6 years ago

if you block any of these;

###ccMedal
##.modal-lg
##.modal-dialog
##.modal
##.modal-content

That'll prevent the download popup from showing.

THEtomaso commented 6 years ago

Seems okay?

No, this doesn't work like users expect it to. After clicking on the "ACCEPT" button, nothing happens.. Only after clicking on the download button for a second time, does the download initialize properly.

If you add the exception that i proposed, the general cookie consent for MSI.com will appear, and the download buttons will work like expected afterwards (on the first try).

ryanbr commented 6 years ago

Unless you're got other filters, its not affected; see https://github.com/AdguardTeam/AdguardFilters/issues/19361

@@||civiccomputing.com^*/cookieControl-$script,domain=msi.com

Currently in the whitelist.

THEtomaso commented 6 years ago

This is the general cookie consent popup dialog at MSI.com, which is blocked by ###ccc-notify:

filterissue-msi1

If the dialog in the screenshot above is blocked, this will appear instead (after clicking on a download button):

filterissue-msi2

The msi.com#@##ccc-notify exception will ensure that the dialog shown in the first screenshot will appear as soon as users visit the site. As a result, the dialog show in the second screenshot (and its erratic behaviour) is avoided!

ryanbr commented 6 years ago

If you click the download arrow again, does it show? shows for me..

THEtomaso commented 6 years ago

Yes, it shows on the second try, but the page doesn't finnish loading and seems to hang on something. When accepting the general consent dialog instead, everything works like expected.

ryanbr commented 6 years ago

it'll be judgement call here, one extra click vs cookie overlay element. I'm happy to leave it