ryanbr / fanboy-adblock

335 stars 57 forks source link

shoppable.com / foodnutritiontable.com / novojornal.co.ao / tappedout.net [Breakage - pages won't load - overlay] [Fanboy’s Annoyance List] #611

Closed kulfoon closed 5 years ago

kulfoon commented 6 years ago

List the website(s) you're having issues:

https://www.shoppable.com/ http://www.foodnutritiontable.com/ http://novojornal.co.ao/ http://tappedout.net/

What happens?

All the websites broken - cookies overlay left (https://www.shoppable.com/ , http://www.foodnutritiontable.com/ and http://tappedout.net/), newsletter overlay left (http://novojornal.co.ao/)

Screenshoots:

screenshoots ### 1 screenshoot (`https://www.shoppable.com/`) - enabling Fanboy’s Annoyance List breaks the website - cookies's overlay left: ![ss1](https://user-images.githubusercontent.com/43844449/47718329-69779200-dc48-11e8-8f62-4cd6435617a0.png) ### 2 screenshoot (`https://www.shoppable.com/`) - disabling Fanboy’s Annoyance List causes the website loading properly (cookie message): ![ss2](https://user-images.githubusercontent.com/43844449/47718439-b8bdc280-dc48-11e8-9e69-482b794842e8.png) ### 3 - screenshoot (`https://www.shoppable.com/`) - clicking Close Cookie button causes the website loading properly: ![ss3](https://user-images.githubusercontent.com/43844449/47718378-8b711480-dc48-11e8-9523-7a0ea4fc8b32.png) ### 4 screenshoot (`http://www.foodnutritiontable.com/`) - enabling Fanboy’s Annoyance List breaks the website - cookies's overlay left: ![ss1](https://user-images.githubusercontent.com/43844449/47719015-274f5000-dc4a-11e8-867d-ca2b7fe88f24.png) ### 5 screenshoot (`http://www.foodnutritiontable.com/`) - disabling Fanboy’s Annoyance List causes the website loading properly (cookie message): ![ss2](https://user-images.githubusercontent.com/43844449/47719077-536ad100-dc4a-11e8-846e-cb2e1af0f0ec.png) ### 6 - screenshoot (`http://www.foodnutritiontable.com/`) - clicking Accept Cookie button causes the website loading properly: ![ss3](https://user-images.githubusercontent.com/43844449/47719115-739a9000-dc4a-11e8-9f91-e0dfe7b13dfa.png) ### 7 screenshoot (`http://tappedout.net/`) - enabling Fanboy's Cookiemonster List breaks the website - newsletter's overlay left: ![ss3](https://user-images.githubusercontent.com/43844449/47951172-4bb66f80-df5d-11e8-8c9c-f122e3457a31.png) ### 8 screenshoot (`http://tappedout.net/`) - disabling Fanboy’s Cookiemonster List causes the website loading properly (cookie message): ![ss1](https://user-images.githubusercontent.com/43844449/47951175-51ac5080-df5d-11e8-843a-6a81cbe42324.png) ### 9 - screenshoot (`http://tappedout.net/`) - clicking accept cookie button causes the website loading properly: ![ss2](https://user-images.githubusercontent.com/43844449/47951174-4eb16000-df5d-11e8-822f-25c2058359bb.png) ### 10 screenshoot (`http://novojornal.co.ao/`) - enabling Fanboy’s Annoyance List breaks the website - newsletter's overlay left: ![ss3](https://user-images.githubusercontent.com/43844449/47771131-5a452280-dce2-11e8-8a1c-40a9e058ad9a.png) ### 11 screenshoot (`http://novojornal.co.ao/`) - disabling Fanboy’s Annoyance List causes the website loading properly (newsletter message): ![ss1](https://user-images.githubusercontent.com/43844449/47771114-51ece780-dce2-11e8-9124-8699000bf11f.png) ### 12 - screenshoot (`http://novojornal.co.ao/`) - clicking close newsletter button causes the website loading properly: ![ss2](https://user-images.githubusercontent.com/43844449/47771135-5dd8a980-dce2-11e8-9c08-c9236eb68e77.png)

List Subscriptions you're using:

uBO default + uBO annoyance + Fanboy’s Annoyance List

Your settings

Other details:

THEtomaso commented 6 years ago

Affected sites:

http://www.foodnutritiontable.com/
http://www.novojornal.co.ao/
https://www.shoppable.com/
http://tappedout.net/

Problem filters:

Problem rules:

##.box-newsletter
##.newsletter-modal
###cookiesModal
###cooMessage
###gdpr-modal

Possible fixes:

foodnutritiontable.com#@##cooMessage
novojornal.co.ao#@#.box-newsletter
novojornal.co.ao#@#.newsletter-modal
shoppable.com#@##cookiesModal
tappedout.net#@##gdpr-modal
kulfoon commented 6 years ago

Your solution works, but I have a question - how then later the cookies messages can be blocked if they are whitelisted by your solution? (as whitelist filters override hiding filters). For ex. adding this: www.foodnutritiontable.com###cooMessage takes no effect as it's whitelisted.

THEtomaso commented 6 years ago

Why would you want to block it, when doing so breaks the entire page?

kulfoon commented 6 years ago

Still ###cooMessage whitelisted by foodnutritiontable.com#@##cooMessage, and ###cookiesModal whitelisted by shoppable.com#@##cookiesModal can't block cookie message.

The purpose of the list is to block Cookies too, so can add missing filters that will hide the overlay: shoppable.com##.in.fade.modal-backdrop foodnutritiontable.com###loading

THEtomaso commented 6 years ago

Removing the generic rules would result in cookie popups on a lot of sites, where those popups easely can be blocked without any ill effects. However, I agree to what you're proposing, to some degree: https://github.com/ryanbr/fanboy-adblock/issues/572#issuecomment-433723010

THEtomaso commented 6 years ago

I guess that it wouldn't be such a bad idea to differentiate between "annoyances" and "cookie consents". There's a reason why uBlock's Annoyances filter leaves such consents alone. Perhaps it would be better if all the cookie rules were to be remove from Fanboy's Annoyance List, and be exclusive to Fanboy's Cookie List?

kulfoon commented 6 years ago

As per https://github.com/ryanbr/fanboy-adblock/issues/611#issuecomment-434303091 Yea, just forgot completely that Fanboy Annoyances contains Fanboy Cookies, I've cleaned my comment above.

As per https://github.com/ryanbr/fanboy-adblock/issues/611#issuecomment-434305570 Can't say now - I would have to think about it.

THEtomaso commented 6 years ago

You're continously forcing me to edit my replies! :)

--

EDIT: I'll just leave my replies alone from now on. If they doesn't make any sense, it's because kulfoon has edited his posts.

kulfoon commented 6 years ago

Yea, I like to edit quickly if possible and clean the noise, rather than to create another comment.

THEtomaso commented 6 years ago

Can't say now - I would have to think about it

The question is for ryanbr. :)

krystian3w commented 5 years ago

Still ###cooMessage whitelisted by foodnutritiontable.com#@##cooMessage, and ###cookiesModal whitelisted by shoppable.com#@##cookiesModal can't block cookie message.

ryanbr commented 5 years ago

Not sure if this would cause any issues, but this helps?

||js.stripe.com^$script,domain=shoppable.com foodnutritiontable.com###loading

Newsletter; shoppable.com###PopupSignupForm_0

ryanbr commented 5 years ago

I had no issues with novojornal.co.ao

krystian3w commented 5 years ago

I had no issues with novojornal.co.ao

Try pruge cookies for this website and catch newsletter.

###modal-newsletter-register
##.newsletter-register
##.box-newsletter

Seems no unlock scroll on first visit. Until the script does not close the newsletter window after 5-15 minutes.

krystian3w commented 5 years ago
modal, .modal-open {
    overflow: hidden;
}
<body class="novojornal page-home modal-open" oncontextmenu="return false;" id="bodyTag" style="padding-right: 17px;">
kulfoon commented 5 years ago

As per https://github.com/ryanbr/fanboy-adblock/issues/611#issuecomment-435299238, yes, it fixes the both issues. As per https://github.com/ryanbr/fanboy-adblock/issues/611#issuecomment-435303049, still the issue is here for me, adding this: novojornal.co.ao##.in.fade.modal-backdrop (for hiding the newsletter's overlay) novojornal.co.ao##body:style(overflow: auto !important;) (for restoring the hidden scroll bar) fixes the issue.

ryanbr commented 5 years ago

novojornal.co.ao##body:style(overflow: auto !important;) isn't ABP compatible.

kulfoon commented 5 years ago

Uh, forgot that the list is for ABP only.

kulfoon commented 5 years ago

Just've found one more http://tappedout.net/, I've edited my 1st comment - screenshoots 7 ,8 ,9.

THEtomaso commented 5 years ago

Unfortunately, from what I've seen of this type of GDPR popup annoyances before, the only properly working solution is to simply allow them:

Post updated: https://github.com/ryanbr/fanboy-adblock/issues/611#issuecomment-434293455

ryanbr commented 5 years ago

Closing ticket, submit a ticket per website, with a suggestion of fix. I dont have the time to go through this.

THEtomaso commented 5 years ago

I've already posted fixes for all of these sites here: https://github.com/ryanbr/fanboy-adblock/issues/611#issuecomment-434293455

kulfoon commented 5 years ago

ryanbr : Closing ticket, submit a ticket per website, with a suggestion of fix. I dont have the time to go through this.

Ok but next time paste the rules into README.md / CONTRIBUTING.md / issue_template.md file rather than in a ticket.

As per the time, others may not have time too.

As for the suggestion of fix - I already have spended enought time to guess that it is one of Fanboy's List causing the issue and I don't want to spend more time to repair someone's mistakes, let authors of bugs fix bugs themselves.

As per the one ticker per website - I intentionally have placed several domains in one ticket to avoid being accused of spamming with too many tickets, but I'll create separate ones then.